Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Restructure funding functions file #296

Merged
merged 1 commit into from
May 20, 2024
Merged

🎨 Restructure funding functions file #296

merged 1 commit into from
May 20, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 14, 2024 •
edited
Loading

What?

  • Restructure all functions in functions.rs into separate submodules

Why?

  • Better readability

How?

Use a similar separation as we did in tests

Testing?

Normal tests run

@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented May 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 05-14-restructure_funding_functions_file branch 3 times, most recently from 5c196e5 to b388810 Compare May 14, 2024 13:32
@JuaniRios JuaniRios self-assigned this May 14, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 14, 2024 15:39
@JuaniRios JuaniRios changed the title restructure funding functions file 🎨 Restructure funding functions file May 14, 2024
@JuaniRios JuaniRios marked this pull request as ready for review May 14, 2024 15:40
@JuaniRios JuaniRios force-pushed the 05-14-restructure_funding_functions_file branch from b388810 to 4a940ca Compare May 16, 2024 11:22
@JuaniRios JuaniRios mentioned this pull request May 16, 2024
Merged
@JuaniRios JuaniRios force-pushed the 05-14-restructure_funding_functions_file branch from 4a940ca to 2ad01e1 Compare May 16, 2024 13:43
@JuaniRios JuaniRios force-pushed the 05-14-restructure_funding_functions_file branch from 2ad01e1 to c7a42f4 Compare May 17, 2024 13:51
vstam1
vstam1 approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JuaniRios JuaniRios merged commit 915327e into main May 20, 2024
@JuaniRios JuaniRios deleted the 05-14-restructure_funding_functions_file branch May 20, 2024 08:27
This was referenced May 20, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 29, 2024
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @vstam1